Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updating logout function on README example code #556

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: Updating logout function on README example code #556

merged 2 commits into from
Jul 24, 2023

Conversation

maitzeth
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Updating README documentation example code. The returnTo parameter has been moved into logoutParams.

References

#550

Testing

N/A

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@maitzeth maitzeth requested a review from a team as a code owner July 24, 2023 21:31
frederikprijck
frederikprijck requested changes Jul 24, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
frederikprijck
frederikprijck approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@frederikprijck frederikprijck enabled auto-merge (squash) July 24, 2023 21:46
@maitzeth
Copy link
Contributor Author

@frederikprijck looks like something went wrong with CI :)

@frederikprijck frederikprijck merged commit 2f1120e into auth0:master Jul 24, 2023
3 checks passed
@maitzeth maitzeth deleted the fix/update-readme-logout-params branch July 24, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maitzeth @frederikprijck